Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for description unable to be set in firewall group #292

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

afady
Copy link
Contributor

@afady afady commented Oct 2, 2019

Description

Fixes issue where description could not be set when creating a firewall group.

Related Issues

#291

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@afady afady requested a review from spencerkordecki October 2, 2019 14:11
@codecov-io
Copy link

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files          21       21           
  Lines         195      195           
  Branches       19       19           
=======================================
  Hits          157      157           
  Misses         38       38
Impacted Files Coverage Δ
src/api/firewall.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8466046...471ad39. Read the comment docs.

@ddymko ddymko merged commit 482d588 into vultr:master Oct 2, 2019
@ddymko ddymko changed the title fix issue #291 Fix for description unable to be set in firewall group Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants