Skip to content

Commit 482d588

Browse files
authored
Merge pull request #292 from afady/firewall-fix
fix issue #291
2 parents 8466046 + 471ad39 commit 482d588

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/api/firewall.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ exports.createGroup = {
3535
requestType: 'POST',
3636
apiKeyRequired: true,
3737
parameters: {
38-
FIREWALLGROUPID: {
38+
description: {
3939
type: 'string',
40-
required: true
40+
required: false
4141
}
4242
}
4343
}

test/api/firewall.test.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ const mock = {
3434
rule_count: 2,
3535
max_rule_count: 50
3636
}
37+
},
38+
createGroup: {
39+
FIREWALLGROUPID: '1234abcd'
3740
}
3841
}
3942

@@ -47,7 +50,7 @@ const mockParameters = {
4750
FIREWALLGROUPID: '1234abcd'
4851
},
4952
createGroup: {
50-
FIREWALLGROUPID: '1234abcd'
53+
description: 'group1'
5154
},
5255
createRule: {
5356
FIREWALLGROUPID: '1234abcd',

0 commit comments

Comments
 (0)