add MuSig related bindings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altafan
reviewed
May 22, 2023
altafan
reviewed
May 22, 2023
altafan
requested changes
May 22, 2023
There was a problem hiding this comment.
@michael1011 the PR looks promising and #44 has been merged along with another PR, so you can now sync this with master to import all those changes.
You should make changes to src/index.d.ts file too and add a MuSig interface to expose the new APIs also on typescript.
You can then try using your fork within other projects to craft txs with these new APIs. If everything looks good, then we'll be super happy to merge these changes and make them effective.
|
BUMP up for review 🙏 |
altafan
approved these changes
Jan 4, 2024
altafan
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #44
This PR adds MuSig related bindings from secp256k1.
Update: works!