Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Docker build #44

Merged
merged 1 commit into from
May 22, 2023
Merged

fix Docker build #44

merged 1 commit into from
May 22, 2023

Conversation

michael1011
Copy link
Contributor

This PR fixes the WASM build in Docker by:

  • updating the emscripten base image of the container
  • removing unexported methods from EXPORTED_FUNCTIONS
  • removing -L${SECP256K1_SOURCE_DIR}/.libs -lsecp256k1 from the last emcc command to fix wasm-ld: error: duplicate symbol errors
  • renaming EXTRA_EXPORTED_RUNTIME_METHODS to EXPORTED_RUNTIME_METHODS because EXTRA_EXPORTED_RUNTIME_METHODS is deprecated

louisinger
louisinger approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@louisinger louisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@michael1011 michael1011 mentioned this pull request May 21, 2023
Merged
altafan
altafan approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@altafan altafan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e48d9b2.

@michael1011 Thank you so much for the contribution!

@altafan altafan merged commit e0cc5a2 into vulpemventures:master May 22, 2023
@michael1011 michael1011 deleted the fix-docker-build branch May 22, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altafan altafan altafan approved these changes

@louisinger louisinger louisinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael1011 @altafan @louisinger