Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ray tracing fixes #2625

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Ray tracing fixes #2625

merged 5 commits into from
Jan 29, 2025

Conversation

marc0246
Copy link
Contributor

This fixes the inconsistencies from #2564. This is mainly just formatting/documentation/conventions:

  • We use .glsl file extensions because they are the most widely supported.
  • 4 space indentation and snake case for GLSL files.
  • The examples weren't consistent with the rest of the examples.
  • Error message/documentation/code style conventions.
  • Some methods weren't documented.
  • trace_rays wasn't taking an array like dispatches do.
  • get_ray_tracing_pipeline_shader_group_handles was scoped wrong.

cc @ComfyFluffy

@marc0246 marc0246 mentioned this pull request Jan 28, 2025
Merged
@ComfyFluffy
Copy link
Contributor

Examples run correctly on my machine.

@Rua Rua merged commit 938de01 into vulkano-rs:master Jan 29, 2025
6 checks passed
@marc0246 marc0246 deleted the ray-tracing-fixes branch January 29, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComfyFluffy ComfyFluffy ComfyFluffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc0246 @ComfyFluffy @Rua