Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray Tracing Pipeline: SBT fixes & refactor examples #2617

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

ComfyFluffy
Copy link
Contributor

@ComfyFluffy ComfyFluffy commented Dec 17, 2024

Changes to examples

  • Use perspective_rh instead of perspective_rh_gl for camera in ray tracing examples.
  • Refactor TLAS builder function in examples to take multiple instances.

Bugs fixed

  • Incorrectly copying handles when shader groups do not follow a specific arrangement.
  • Specify alignment when creating SBT buffers.

@Rua
Copy link
Contributor

Rua commented Jan 28, 2025

How are things going with this PR?

@ComfyFluffy
Copy link
Contributor Author

Docs for trace_rays is not added yet. I think I will add them this week. Other modifications should be ready for review.

@marc0246
Copy link
Contributor

I documented all the methods in #2625.

@ComfyFluffy
Copy link
Contributor Author

I will migrate the changes based on #2625.

@ComfyFluffy ComfyFluffy changed the title Ray Tracing Pipeline: Additional Docs and Bug Fixes Ray Tracing Pipeline: SBT copy fixes & refactor examples Jan 29, 2025
@ComfyFluffy ComfyFluffy marked this pull request as ready for review January 29, 2025 06:31
@ComfyFluffy
Copy link
Contributor Author

New changes are ready for review. I can merge from master once #2625 is merged.

@ComfyFluffy ComfyFluffy changed the title Ray Tracing Pipeline: SBT copy fixes & refactor examples Ray Tracing Pipeline: SBT fixes & refactor examples Jan 29, 2025
@marc0246
Copy link
Contributor

Thank you for the fixes!

Please don't create dependencies between PRs when there's no need. I think what you wanted is for me to not get merge conflicts, but please don't worry yourself with that. I'm a seasoned veteran when it comes to merge conflicts. Focus on your PR containing only your commits unless someone asks you to consider a specific merge order or unless it's unavoidable.

@marc0246 marc0246 merged commit 6ae10df into vulkano-rs:master Jan 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants