Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validatable): revalidate on rules change #4640

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

Description

Motivation and Context

fixes #4635

How Has This Been Tested?

visually

Markup:

<template>
<v-app>
  <v-content>
    <v-container>
      <v-text-field v-model="a" :rules="validation" />
      <v-text-field v-model="errorMessage" />
    </v-container>
  </v-content>
</v-app>
</template>

<script>
  export default {
    data: () => ({
      a: '',
      errorMessage: 'error',
    }),

    computed: {
      validation () {
        return [(message => v => !v || message)(this.errorMessage)]
      }
    }
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

Other comments

Don't know how to reproduce the issue from the removed comment

@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Jul 17, 2018
KaelWD
KaelWD previously approved these changes Jul 18, 2018
@KaelWD KaelWD merged commit 0693334 into master Jul 18, 2018
@KaelWD KaelWD deleted the fix/#4635-revalidate-on-rule-change branch July 18, 2018 07:35
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this pull request Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this pull request Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this pull request Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this pull request Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
KaelWD added a commit that referenced this pull request Oct 28, 2018
arrays aren't interned

kinda caused by #4640
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] bound input rules are not called after they are changed
2 participants