Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] bound input rules are not called after they are changed #4635

Closed
Taipeek opened this issue Jul 17, 2018 · 8 comments · Fixed by #4640
Closed

[Bug Report] bound input rules are not called after they are changed #4635

Taipeek opened this issue Jul 17, 2018 · 8 comments · Fixed by #4640
Assignees
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Milestone

Comments

@Taipeek
Copy link

Taipeek commented Jul 17, 2018

Versions and Environment

Vuetify: 1.1.4
Vue: 2.5.16
Browsers: Chrome 67.0.3396.99
OS: Windows 10

Steps to reproduce

Type something into the input.
A test message generated in the rules prop will show up.
Click on the change validation button

Expected Behavior

The message should disappear since the rules are now different

Actual Behavior

The message is still visible and only disappears after the input model is updated

Reproduction Link

https://codepen.io/taipeek/pen/GBqKeq

@jacekkarczmarczyk
Copy link
Member

You're issue is valid, but the reproduction is not - it doesn't change the rules after clicking the button, see the Playground.vue in PR for this issue

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Jul 17, 2018
@KaelWD KaelWD added this to the v1.1.x milestone Jul 18, 2018
@KaelWD KaelWD closed this as completed in 0693334 Jul 18, 2018
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this issue Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this issue Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this issue Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this issue Jul 18, 2018
* fix(validatable): revalidate on rules change

fixes vuetifyjs#4635

* style: remove unused params
@andtii
Copy link

andtii commented Jul 30, 2018

Saw that this was fixed in 1.1.6 but tested the same codepen as submitted now running on vuetify 1.1.8 and it still dosent work as expected. When the validation rule changes you have to type something in the input for the new validation to trigger. The excpeted behavior would be to run the validation when clicking on button and add/remove the error. @KaelWD @jacekkarczmarczyk

https://codepen.io/taipeek/pen/GBqKeq

@KaelWD
Copy link
Member

KaelWD commented Jul 30, 2018

53ad130

Check the log, computed.validation is only run once.

@Taipeek
Copy link
Author

Taipeek commented Jul 30, 2018

@KaelWD That is true but in this fixed codepen: https://codepen.io/taipeek/pen/PBEGZR in version 1.1.8 the issue is still there. Check the console output which shows what should be the expected rule when clicked on the button. However the input doesn't show the rule.

@andtii
Copy link

andtii commented Aug 1, 2018

@Taipeek Exactly, this is the issue i have aswell. Can you confirm @KaelWD

@Taipeek
Copy link
Author

Taipeek commented Aug 13, 2018

@KaelWD @jacekkarczmarczyk just reminding that this issue is not solved in 1.1.11.

@andtii
Copy link

andtii commented Aug 23, 2018

@KaelWD @jacekkarczmarczyk @johnleider Any updates on this issue?

@KaelWD
Copy link
Member

KaelWD commented Aug 23, 2018

No, and I don't know if it's possible with callback-based validation. This has been through several iterations and all of them caused more serious issues with much more common use cases.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants