-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] bound input rules are not called after they are changed #4635
Comments
You're issue is valid, but the reproduction is not - it doesn't change the rules after clicking the button, see the Playground.vue in PR for this issue |
* fix(validatable): revalidate on rules change fixes vuetifyjs#4635 * style: remove unused params
* fix(validatable): revalidate on rules change fixes vuetifyjs#4635 * style: remove unused params
* fix(validatable): revalidate on rules change fixes vuetifyjs#4635 * style: remove unused params
* fix(validatable): revalidate on rules change fixes vuetifyjs#4635 * style: remove unused params
Saw that this was fixed in 1.1.6 but tested the same codepen as submitted now running on vuetify 1.1.8 and it still dosent work as expected. When the validation rule changes you have to type something in the input for the new validation to trigger. The excpeted behavior would be to run the validation when clicking on button and add/remove the error. @KaelWD @jacekkarczmarczyk |
Check the log, |
@KaelWD That is true but in this fixed codepen: https://codepen.io/taipeek/pen/PBEGZR in version 1.1.8 the issue is still there. Check the console output which shows what should be the expected rule when clicked on the button. However the input doesn't show the rule. |
@KaelWD @jacekkarczmarczyk just reminding that this issue is not solved in 1.1.11. |
@KaelWD @jacekkarczmarczyk @johnleider Any updates on this issue? |
No, and I don't know if it's possible with callback-based validation. This has been through several iterations and all of them caused more serious issues with much more common use cases. |
Versions and Environment
Vuetify: 1.1.4
Vue: 2.5.16
Browsers: Chrome 67.0.3396.99
OS: Windows 10
Steps to reproduce
Type something into the input.
A test message generated in the rules prop will show up.
Click on the change validation button
Expected Behavior
The message should disappear since the rules are now different
Actual Behavior
The message is still visible and only disappears after the input model is updated
Reproduction Link
https://codepen.io/taipeek/pen/GBqKeq
The text was updated successfully, but these errors were encountered: