Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable react client components #3148

Merged
merged 5 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"hygen": "^6.2.8",
"prettier": "latest",
"rimraf": "^5.0.0",
"rollup-plugin-preserve-directives": "^0.4.0",
"tailwindcss": "^3.4.3",
"turbo": "latest",
"typescript": "^5.4.5",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import { forwardRef } from 'react';
import type { MouseEvent } from 'react';
import classNames from 'classnames';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import classNames from 'classnames';
import { useRef } from 'react';
import { useClickAway } from 'react-use';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import classNames from 'classnames';
import { useDropdown } from '@storefront-ui/react';
import type { SfDropdownProps } from '@storefront-ui/react';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import classNames from 'classnames';
import { useRef } from 'react';
import { useClickAway } from 'react-use';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import { useState, type ChangeEvent } from 'react';
import classnames from 'classnames';
import {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
/* eslint-disable react/require-default-props */
import { cloneElement, useMemo } from 'react';
import classNames from 'classnames';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import { KeyboardEvent, useState } from 'react';
import classNames from 'classnames';
import { SfSelectSize, SfIconExpandMore, composeHandlers, useFocusVisible } from '@storefront-ui/react';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import classNames from 'classnames';
import { SfTextareaSize, useFocusVisible } from '@storefront-ui/react';
import { forwardRef } from 'react';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
'use client';
import { useTooltip } from '@storefront-ui/react';
import type { SfTooltipProps } from '@storefront-ui/react';

Expand Down
10 changes: 9 additions & 1 deletion packages/sfui/frameworks/react/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'vite';
import dts from 'vite-plugin-dts';
import react from '@vitejs/plugin-react';
import tsconfigPaths from 'vite-tsconfig-paths';

import preserveDirectives from 'rollup-plugin-preserve-directives';
import pkg from './package.json';

export default defineConfig({
Expand Down Expand Up @@ -36,6 +36,14 @@ export default defineConfig({
preserveModules: true,
preserveModulesRoot: './',
},
plugins: [preserveDirectives()],
onwarn(warning, warn) {
// https://github.com/vitejs/vite-plugin-react/issues/137
if (warning.code === 'MODULE_LEVEL_DIRECTIVE') {
return;
}
warn(warning);
},
},
},
});
13 changes: 13 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4521,6 +4521,7 @@ __metadata:
hygen: ^6.2.8
prettier: latest
rimraf: ^5.0.0
rollup-plugin-preserve-directives: ^0.4.0
tailwindcss: ^3.4.3
turbo: latest
typescript: ^5.4.5
Expand Down Expand Up @@ -21693,6 +21694,18 @@ __metadata:
languageName: node
linkType: hard

"rollup-plugin-preserve-directives@npm:^0.4.0":
version: 0.4.0
resolution: "rollup-plugin-preserve-directives@npm:0.4.0"
dependencies:
"@rollup/pluginutils": ^5.1.0
magic-string: ^0.30.5
peerDependencies:
rollup: 2.x || 3.x || 4.x
checksum: 457ca1f60d2cdbe5485339dbc4b228bec5684a99b6589c771bc2268ffaeb29dce2d248f83a85da2fbf572a23cc592d7f59e6485369965210df1035f22ce67feb
languageName: node
linkType: hard

"rollup-plugin-visualizer@npm:^5.12.0":
version: 5.12.0
resolution: "rollup-plugin-visualizer@npm:5.12.0"
Expand Down
Loading