feat: enable react client components #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razz21
requested review from
Szymon-dziewonski,
FRSgit,
mattmaribojoc,
filrak and
skirianov
as code owners
🦋 Changeset detectedLatest commit: 34b7107 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Razz21
changed the title
jagoral
reviewed
May 10, 2024
Razz21
removed request for
Szymon-dziewonski,
FRSgit,
filrak,
mattmaribojoc and
skirianov
jagoral
reviewed
May 13, 2024
packages/sfui/frameworks/react/components/SfButton/SfButton.tsx
Outdated
Show resolved
Hide resolved
jagoral
reviewed
May 13, 2024
packages/sfui/frameworks/react/components/SfCheckbox/SfCheckbox.tsx
Outdated
Show resolved
Hide resolved
jagoral
reviewed
May 13, 2024
jagoral
reviewed
May 13, 2024
jagoral
reviewed
May 13, 2024
jagoral
reviewed
May 13, 2024
packages/sfui/frameworks/react/components/SfListItem/SfListItem.tsx
Outdated
Show resolved
Hide resolved
Razz21
force-pushed
the
feat/react-client-components
branch
from
4094e77 to
69c3659
Compare
jagoral
approved these changes
May 13, 2024
added 3 commits
May 13, 2024 13:20
This reverts commit 396e4a9.
Szymon-dziewonski
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #
Scope of work
Updates SFUI React components build to inject "use client" directive to each file.
This update enables SFUI library for using with Next App Router.
Screenshots of visual changes
Checklist