Support target="_blank" for <router-link>
#830
Conversation
| // don't redirect if `target="_blank"` | ||
| /* istanbul ignore if */ | ||
| const target = this.$el && this.$el.attributes.getNamedItem('target') | ||
| if (target && target.value === '_blank') return |
There was a problem hiding this comment.
Two things:
- Why not
const target = this.$el && this.$el.getAttribute('target')? - Won't this fail for
target="_blank "(with an extra space)?
There was a problem hiding this comment.
Fixed, I guess I'm just too unfamiliar with native dom api 😂
| // don't redirect if `target="_blank"` | ||
| /* istanbul ignore if */ | ||
| const target = this.$el && this.$el.getAttribute('target') | ||
| if (target && target.toLowerCase().split(' ').indexOf('_blank') > -1) return |
There was a problem hiding this comment.
Since code is written in ES Net, shouldn't it be target.toLowerCase().split(' ').includes('_blank')?
There was a problem hiding this comment.
That cannot be transpiled, and would require a polyfill.
There was a problem hiding this comment.
how about just /\b_blank\b/i.test(target)
|
@fnlctrl I absolutely forgot about this, sorry |
|
@posva Totally forgot this too 😂😂😂 |
| @@ -49,6 +49,11 @@ export default { | |||
| // don't redirect on right click | |||
| /* istanbul ignore if */ | |||
| if (e.button !== 0) return | |||
| // don't redirect if `target="_blank"` | |||
| /* istanbul ignore if */ | |||
| const target = this.$el && this.$el.getAttribute('target') | |||
There was a problem hiding this comment.
We should use e.target here. this.$el may be a wrapping <li> if tag prop is used.
| // don't redirect if `target="_blank"` | ||
| /* istanbul ignore if */ | ||
| const target = this.$el && this.$el.getAttribute('target') | ||
| if (target && target.toLowerCase().split(' ').indexOf('_blank') > -1) return |
There was a problem hiding this comment.
how about just /\b_blank\b/i.test(target)
|
@yyx990803 , hello you da, but how can I do it in the instance, like this:
|
|
If it's supported you should update this line. |
No description provided.