-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 doesn't respect target="_blank" attr #827
Comments
It's no longer supported, please use |
Manually creating links is error prone and can't be really considered solution — аlas, router instance doesn't provide method for reverse url resolving. I understand that this is quite rare use case, but this is obvious regression and as such should be at least mentioned in upgrade guide. |
It has.. though it's not documented (since it's very unlikely that someone needs it):
Sorry about that, just created a PR to fix this: https://github.com/vuejs/vuejs.org/pull/539/files |
Yeah, I already dug out this method, although it's not full equivalent of what's happening in |
Yeah, it doesn't handle
It's unlikely to be documented, and I can't guarantee its consistence... Please use at your own risk. |
@fnlctrl Couldn't we implement this with |
@fnlctrl I think we should 😄 |
@fnlctrl while target="_blank" is indeed corner case, reverse url resolve can be useful in other cases. Imagine we're building isomorphic app and we need to email user some link. Or we doing something like google drive or bit.ly and we need to provide links in text form to copy them. |
Sidenote: Is that kind of behaviour necessary? |
fixed by merging #830 |
Following code doesn't open new tab/window:
I'm upgrading my app from 1.x where appropriate equivalent of this code worked. Here's repro pen: http://codepen.io/hogart/pen/ZpPGXY?editors=1010
The text was updated successfully, but these errors were encountered: