Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .sass formatting #1658

Merged
merged 3 commits into from
Feb 11, 2020
Merged

add .sass formatting #1658

merged 3 commits into from
Feb 11, 2020

Conversation

TheRealSyler
Copy link
Contributor

@TheRealSyler TheRealSyler commented Jan 19, 2020 •
edited
Loading

should pass the tests and be ready to merge.

related to #1433

@TheRealSyler TheRealSyler mentioned this pull request Jan 19, 2020
Closed
@TheRealSyler TheRealSyler requested a review from octref February 1, 2020 08:16
octref
octref requested changes Feb 10, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just some minor clarification and nitpicks

package.json Outdated Show resolved Hide resolved
server/src/modes/style/sass/sassLanguageMode.ts Outdated Show resolved Hide resolved
@TheRealSyler TheRealSyler requested a review from octref February 10, 2020 21:10
@octref octref merged commit 8b82c92 into vuejs:master Feb 11, 2020
@octref
Copy link
Member

octref commented Feb 11, 2020

Thanks!

@octref octref mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealSyler @octref