Sass Formatter #1434
Sass Formatter #1434
Conversation
| deleteWhitespace: true, | ||
| replaceSpacesOrTabs: true, | ||
| setPropertySpace: true | ||
| }; |
There was a problem hiding this comment.
Can you extract this into an interface exported from this file? We might have a default config at some point.
There was a problem hiding this comment.
i already made the interface here, i can just import the it from sass-formatter, maintaining two instances of the same interface seems unnecessary.
| setPropertySpace: true | ||
| }; | ||
| if (this.config.sass && this.config.sass.format) { | ||
| sassConfig = this.config.sass.format; |
There was a problem hiding this comment.
Use Object.assign(this.config.sass.format, sassConfig) to merge them.
There was a problem hiding this comment.
added in the newest commit.
|
Good work. Thanks a lot! I have added docs and pushed an integration test. Left some comments as well. |
|
i couldn't test it locally because i installed linux, and i get an error when i try to start the debug server, but this should address your comments, and in theory it should work without braking anything, but every time i think this should work something brakes. |
|
Retriggering CI |
|
moved to #1658 |
Related to #1433
not sure if the return values of the unused functions in the
SassLanguageModeare an issue.