Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat-card-damage #69

Closed
wants to merge 2 commits into from
Closed

Conversation

RabidOwlbear
Copy link
Collaborator

Adds a setting allowing gm to select the target of damage applied via chat message roll result.
Selecting 'targeted' applies damage to the targeted token actors.
Selecting 'selected' applies damage to the selected token actors

@anthonyronda anthonyronda self-requested a review January 30, 2022 15:14
@@ -82,4 +82,17 @@ export const registerSettings = function () {
config: true,
onChange: _ => window.location.reload()
});
game.settings.register('ose', 'applyDamageOption', {
name: game.i18n.localize('OSE.Setting.applyDamageOption'),
hint: game.i18n.localize('OSE.Setting.applyDamageOptionHint'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I'll have to write some strings for these

canvas.tokens.controlled.forEach(async t=>{
if(game.user.isGM) return await t.actor.applyDamage(amount,multiplier)
})
}

Copy link
Member

@anthonyronda anthonyronda Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error, missing }

Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like for me to help complete your contribution, please give the word. I have a commit fixing:

  • missing closing bracket
  • new i18n strings for the new setting

@anthonyronda
Copy link
Member

New PR in #70

@RabidOwlbear RabidOwlbear deleted the chat-card-damage branch February 17, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants