Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Damage Application Settings #5

Closed
justinthejaguar opened this issue Jan 2, 2022 · 4 comments
Closed

Confusing Damage Application Settings #5

justinthejaguar opened this issue Jan 2, 2022 · 4 comments
Assignees
Labels
bug Something isn't working combat Anything related to combat (initiative tracker, attacking, etc.)

Comments

@justinthejaguar
Copy link

In order to get a read out for attack damage vs [enemy] one needs to target the token they wish to attack with the correct attacking creature selected.
image
This creates a card showing that the selected character inflicts damage. It does not automatically apply the damage to the target.
image
Instead when you hover over the damage you are given a damage application button
image
Hitting this button applies the damage to the selected token (not the targeted one that should be taking the damage.
image

This method would probably make more sense if the targeting feature of printing the vs enemy card didn't exist, and if the player isn't targeting enemies it would always be helpful.

Is there anyway to update this so that the damage could be auto applied to the targeted token with the option to undo the damage in chat?

@freohr freohr added bug Something isn't working combat Anything related to combat (initiative tracker, attacking, etc.) labels Jan 17, 2022
@anthonyronda
Copy link
Member

@RabidOwlbear has a fix for this in #69, and created a setting to switch the behavior from selected tokens to targeted tokens. I'm curious, would you like the default to be selected or targeted?

@archibael
Copy link

I feel like default should be targeted. If in the future we want to add something like attack icons that appear when the token is selected, we'll want to be able to select the attacker and the target simultaneously, and hard to do that (not to mention self-destructive ;) ) if the damage auto-applies to selected.

@justinthejaguar
Copy link
Author

justinthejaguar commented Jan 30, 2022

I think default to targeted is ideal if we have auto damage application, but after running the system quite a bit, I’ve noticed that the gm isn’t typically targeting the token of the pc, so I’m understanding the intent of it hitting the selected token instead.

maybe the best approach is if there is no target apply to selected. *edit typo

@anthonyronda
Copy link
Member

Merged the fix #70, which is a new PR to complete the contribution with translation strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working combat Anything related to combat (initiative tracker, attacking, etc.)
Projects
None yet
Development

No branches or pull requests

5 participants