Character sheet inventory fixes #500
Conversation
Henrik-Bonsmann
commented
Feb 7, 2024
Henrik-Bonsmann
commented
- fixed encumbrance bar and breakpoints
- fixed "double weight" issue for treasure weight calculation
- fixed treasure value total in Treasure header
- Unified weight display across Treasure, Misc and Container items to be multiplied with item number
+ specified steps for complete and detailed encumbrance separately + fixed treasure weight in the item list
* Item weight calculation now takes quantity into account for Misc items and stuff in containers, making it consistent with treasures
|
fixes #498 |
src/module/actor/data-model-classes/data-model-character-encumbrance-detailed.ts
Outdated
Show resolved
Hide resolved
*To avoid excessive handlebar maths in the inventory tab, derive the product of quantity and (weight, cost & itemslots) in the item dataModel. * Set default quantity of new items to 1 to avoid confusion.
src/module/actor/data-model-classes/data-model-character-encumbrance-complete.ts
Outdated
Show resolved
Hide resolved
| value: new NumberField({ integer: false }), | ||
| max: new NumberField({ integer: false }), | ||
| }), | ||
| encumbrance: new ObjectField(), |
There was a problem hiding this comment.
Would you mind trying something?
| encumbrance: new ObjectField(), | |
| encumbrance: new SchemaField({ | |
| max: new NumberField({ initial: 1600 }), | |
| }), |
See if that fixes it, as well. My guess is that we haven't been setting an initial encumbrance max all this time.
If it doesn't work, eh, heck with it, we'll keep it as you have it. If it does, then maybe we add a system setting for default initial value for max carry weight?
There was a problem hiding this comment.
That makes it worse. If I see things correctly, setting a SchemaField() here makes it impossible to add other variables to it from the data-model-classes, so everything not specified will never be exposed, which is also why #467 looks as is does with this massive schema field.
This is also consistent with prior behavior, because setting the missing max in "Tweaks" did not actually resolve the issue of no bar or breakpoints.
There was a problem hiding this comment.
Huh. Fair enough. It was worth a try.
We may want to add a migration to ensure that null/undefined values for encumbrance.max are set to 1600 when this goes out. That default gets pulled from template.json if we're not specifically setting a schema field up for it.
Unified encumbrance classes to utilize a shared set of bools for speed calculation
src/module/item/data-model-item.js
Outdated
| max: new NumberField({ min: 0, initial: 0 }), | ||
| }), | ||
| weight: new NumberField({ min: 0, initial: 0 }), | ||
| itemslots: new NumberField({ min: 0, initial: 0 }), | ||
| }; | ||
| } | ||
| get cummulativeWeight(){ |
There was a problem hiding this comment.
Typo.
| get cummulativeWeight(){ | |
| get cumulativeWeight(){ |
|
@all-contributors add Henrik-Bonsmann for code |
|
I've put up a pull request to add @Henrik-Bonsmann! 🎉 |
