Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Inventory not reading external values #498

Closed
1 task done
Henrik-Bonsmann opened this issue Jan 20, 2024 · 1 comment
Closed
1 task done

Character Inventory not reading external values #498

Henrik-Bonsmann opened this issue Jan 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working triage This bug still needs to be validated and weighted

Comments

@Henrik-Bonsmann
Copy link
Contributor

What happened?

In the character inventory, the "Treasure" value, encumbrance bar and encumbrance break-points are missing.
Inspecting the element reveals that several handlebars are returning null-values.

In character-inventory-tab.html:

    <div class="field-long">
      {{system.treasure}} <i class="fas fa-circle"></i>
    </div>

(line 312 f)

<section>
  {{#with @root.system.encumbrance}}
  <div class="encumbrance {{#if encumbered}}encumbered{{/if}}">
    <span class="encumbrance-bar" style="width:{{pct}}%"></span>
    <span class="encumbrance-label">{{value}} / {{max}}</span>
    {{#each steps as |s|}}
    <i class="encumbrance-breakpoint arrow-up" style="left:{{s}}%"></i>
    <i class="encumbrance-breakpoint arrow-down" style="left:{{s}}%"></i>
    {{/each}}
  </div>
  {{/with}}
</section>

(line 373 ff)

{{system.treasure}}, {{pct}} and {{s}} return Null while {{value}}and {{max}} work fine.

What is the expected behaviour?

Showing the treasure bar with movement break-points and the sum of treasure is vital for keeping bookkeeping low and the game fun and fast paced.

The inventory sheet can be seen working as intended in the guide:
https://ose.vtt.red/images/inventory.png

Relevant Errors and Warnings

No response

Additional Support Details

Foundry: 11.315
OSE: 1.9.4
Client: foundry.exe

Foundry VTT Core Version

None

Old-School Essentials Core Version

No response

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Other

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Henrik-Bonsmann Henrik-Bonsmann added bug Something isn't working triage This bug still needs to be validated and weighted labels Jan 20, 2024
@anthonyronda
Copy link
Member

Closed #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This bug still needs to be validated and weighted
Projects
None yet
Development

No branches or pull requests

2 participants