Get spell dice rolling #497
Conversation
apewall
force-pushed
the
roll-spell-chat-card
branch
from
3630028 to
8fc4491
Compare
apewall
force-pushed
the
roll-spell-chat-card
branch
from
711998f to
637ae26
Compare
| <div class="blindable" data-blind="{{data.roll.blindroll}}"> | ||
| {{#if result.details}}<div class="chat-details">{{{result.details}}}</div>{{/if}} | ||
| {{#if result.isFailure}}<div class='roll-result roll-fail'><b>{{localize 'OSE.Failure'}}</b> ({{result.target}}) | ||
| </div>{{/if}} | ||
| {{#if result.isSuccess}}<div class='roll-result roll-success'><b>{{localize 'OSE.Success'}}</b> | ||
| ({{result.target}})</div>{{/if}} | ||
| {{#if rollOSE}}<div>{{{rollOSE}}}</div>{{/if}} | ||
| {{#if data.save}} |
There was a problem hiding this comment.
Does this come from rollData.roll.save or rollData.save?
There was a problem hiding this comment.
This comes from RollData.save, I've removed rollData.roll.save as it is not needed.
|
Thanks for your review! @all-contributors add @Henrik-Bonsmann for review |
|
@all-contributors add @Henrik-Bonsmann for review |
|
I've put up a pull request to add @thanks! 🎉 I've put up a pull request to add @Henrik-Bonsmann! 🎉 |
|
@Henrik-Bonsmann already contributed before to review EDIT: Nope! First time |
|
@apewall I'm manually testing this PR right now. I'll send the review shortly |
While I think that this should be something that's flagged to the user, I don't like the idea of outright preventing the cast. It enforces the use of the automation too much and has the potential to introduce a lot of annoyance for players. If the preparation was the mistake (instead of the casting), you'd have to open the sheet, navigate to spells, find the correct one, prepare it and then redo (or at least check) all the steps you need to take to cast the spell in the first place. A warning here is a lot better UX-wise. The best solution for my money would be a "cast anyway" button. |
Thinking it over I largely agree. This should probably be a larger discussion about how we display warnings and allow users the option override the automation via a popup instead. Ill revert for now. |
apewall
force-pushed
the
roll-spell-chat-card
branch
from
b756e01 to
4e2f094
Compare
I only used the discussion in #382 as a reference for what information should be provided on spell cards when rolled. It's not meant to address the Automation Animation module (Which seems to be in maintenace mode anyway). |
|
@all-contributors add apewall for code |
|
I've put up a pull request to add @apewall! 🎉 |
This change will make spells roll-able from the character sheet when spells have a roll parameter set. It also adds saves, the footer, and tags to generated cards for both spells and abilities. Spells will show their descriptions when rolled, but abilities will not.
This brings spells and abilities in line with how weapon attacks rolls function, and should meet the expectations of #382.
Old spell Card
New spell card
Old ability card
New ability card
