Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulesync 3.1.0 #11

Merged
merged 2 commits into from
Nov 25, 2020
Merged

modulesync 3.1.0 #11

merged 2 commits into from
Nov 25, 2020

Conversation

bastelfreak
Copy link
Member

modulesync 3.1.0

@alexjfisher
Copy link
Member

@ekohl Did you see 26eb28d and remember our discussion on modulesync_config?

@ekohl
Copy link
Member

ekohl commented Oct 27, 2020

Yes I did. I think this was literally the only exception. However, this case:

# Offense count: 1
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
# NamePrefix: is_, has_, have_
# NamePrefixBlacklist: is_, has_, have_
# NameWhitelist: is_a?
Style/PredicateName:
Exclude:
- "lib/puppet/type/xmlfile.rb"

That's just implementing the Puppet API so perhaps it should be disabled inline instead.

@alexjfisher
Copy link
Member

@ekohl Did you see 26eb28d and remember our discussion on modulesync_config?

@bastelfreak bastelfreak merged commit 042a4e7 into master Nov 25, 2020
@bastelfreak bastelfreak deleted the modulesync branch November 25, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants