Use Rubocop config from voxpupuli-test

[ekohl]

This is still a draft since it depends on voxpupuli/voxpupuli-test#28 and assumes that will be released as version 2.1.0.

[alexjfisher]

Should we include a inherit_from: .rubocop_todo.yml as well?

[ekohl]

None of our modules have this today and if the file doesn't exist, Rubocop hard crashes with No such file or directory. I'd say this file is now trivial enough that if they need a TODO, they can unmanage the file.

[alexjfisher]

Oh, that’s annoying. Since it’s still erb, can It dynamically add the line if the file exists?
I’m thinking it might be useful when we finally drop ruby 1.9 support at the end of the year.

[ekohl]

Technically yes and the recent support in modulesync does make that easier (since you get a variable for the target directory).

[alexjfisher]

We can always add this later.

[ekohl]

Now that 2.1 has been released, this is ready for review. I'd prefer to leave out the TODO file since that's not really used in our modules and I'd like to avoid encouraging it. That's also a nice way of saying that I'm too lazy to write the code for it ;)

[alexjfisher]

Now that 2.1 has been released, this is ready for review. I'd prefer to leave out the TODO file since that's not really used in our modules and I'd like to avoid encouraging it. That's also a nice way of saying that I'm too lazy to write the code for it ;)

I think it'll be useful when/if we finally bump to much newer versions of rubocop after we drop ruby 1.9 support. But we don't need it right now, so +1 from me.