Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 11 support #352

Closed
wants to merge 2 commits into from
Closed

Add Debian 11 support #352

wants to merge 2 commits into from

Conversation

jbrnfnd
Copy link

@jbrnfnd jbrnfnd commented Oct 15, 2021

Pull Request (PR) description

This PR enables support for Debian 11 by adding a yaml file, 11.yaml in the Debian subfolder
It is a straight renamed copy of 10.yaml

@ghoneycutt
Copy link
Member

ghoneycutt commented Oct 15, 2021

Thanks for the contribution! For this module to support Debian 11, it needs to be recorded in the metadata - https://github.com/voxpupuli/puppet-selinux/blob/master/metadata.json

@smortex
Copy link
Member

smortex commented Oct 16, 2021

I think you can fix CI by improving:

if $facts['os']['selinux']['enabled'] {

-  if $facts['os']['selinux']['enabled'] {
+  if fact('os.selinux.enabled') {

@jbrnfnd
Copy link
Author

jbrnfnd commented Nov 2, 2021

Hi,

From the documentation, the squared bracket syntax is also supported in Puppet 5.5
https://puppet.com/docs/puppet/5.5/lang_facts_and_builtin_vars.html#the-factsfact_name-hash
I don't know why this is failing, as the syntax is the same used as in older versions of puppet-selinux
As puppet5 is EOL since end of january 2021, why it is still in the CI workflow?
Wouldn't it be better to only support active Puppet versions?

@ghoneycutt
Copy link
Member

You can remove Puppet5 support, though please do in a separate PR.

@cmseal
Copy link

cmseal commented Feb 15, 2022

Hi. Aside from the EOL Puppet 5 test and Puppet 5 support requested to be removed in a separate PR, is there anything else required to move this forwards?

@jbrnfnd
Copy link
Author

jbrnfnd commented Feb 15, 2022

Hi, due to work related things i am completely stalled here. i would like to post a pull request but don't know how.
the yml files in .github/workflows do not indicate to exclude puppet 5 in my opinion.

@ekohl
Copy link
Member

ekohl commented Feb 15, 2022

It's because of this line:

"version_requirement": ">= 5.5.8 < 8.0.0"

If you update that (preferably to >= 6.1.0) then it should stop testing on Puppet 5.

@laser-dev-support
Copy link

Hi, any update on this PR? We really need to have it working on Debian 11.

thanks a lot

f.

@ekohl
Copy link
Member

ekohl commented Dec 9, 2022

I opened #361 & #362

@ekohl
Copy link
Member

ekohl commented Dec 9, 2022

Solved via #359 instead.

@ekohl ekohl closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants