Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax_tools to extra_applications to fix compilation on Elixir 1.15 #53

Conversation

michallepicki
Copy link

@michallepicki michallepicki commented Feb 17, 2023

I saw somewhere a mention that this is a compile-only dependency? Unfortunately I don't know how it should be declared to be present during compilation but not when application starts. Maybe this is what syntax_tools: :optional in :extra_applications would do but I haven't tested building a release with this value.

to fix compilation on Elixir 1.15
@KiKoS0
Copy link

KiKoS0 commented May 30, 2023

I have the same issue compiling with Elixir 1.15. I tried building a release with syntax_tools: :optional but :epp_dodger was still bundled in it. Is it fine to merge this to unblock upgrades until a better way to achieve this is found?

@wojtekmach
Copy link
Contributor

I have reported this upstream: elixir-lang/elixir#12622

@wojtekmach
Copy link
Contributor

I have submitted a proper fix: #60

@michallepicki
Copy link
Author

Closing in favor of #60

@michallepicki michallepicki deleted the explicitly-list-syntax-tools-as-dependency branch May 31, 2023 05:02
@michallepicki michallepicki restored the explicitly-list-syntax-tools-as-dependency branch May 31, 2023 05:02
@voltone
Copy link
Owner

voltone commented May 31, 2023

I released v0.8.7 with the fix from #60. Thanks @wojtekmach !

@michallepicki michallepicki deleted the explicitly-list-syntax-tools-as-dependency branch June 28, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants