Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler(warnings): Fix compiler warning emitted from elixir 1.11.0 #38

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

tomciopp
Copy link
Contributor

@tomciopp tomciopp commented Oct 6, 2020

@voltone A bunch of new compiler warnings are emitted when using elixir 1.11.0. I've included one below as an example.

warning: IEx.started?/0 defined in application :iex is used by the current application but the current application does not directly depend on :iex. To fix this, you must do one of:

  1. If :iex is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :iex is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :iex, you may optionally skip this warning by adding [xref: [exclude: IEx] to your "def project" in mix.exs

  lib/mix/tasks/x509.test_server.ex:104: Mix.Tasks.X509.TestServer.iex_running?/0

@voltone
Copy link
Owner

voltone commented Oct 11, 2020

Thanks for the PR @tomciopp !

I would like to keep :iex and :syntax_tools out of the list of extra applications, since they really should not be bundled into a release just because x509 is. The former is only called after calling Code.ensure_loaded?(IEx) to detect when IEx is active, and the latter is a compile-time only dependency.

So I would propose to remove those and add the xref: [exclude: [IEx, :epp_dodger]] project option.

@tomciopp
Copy link
Contributor Author

@voltone updated

@voltone
Copy link
Owner

voltone commented Oct 13, 2020

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants