vdk-core: properties write pre-processing support #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces `IPropertiesServiceClient` `write_properties` chaining, enabling use-cases like decorate/curate properties prior write, parallel properties storage, and so on. In addition, autonomous `IPropertiesServiceClient` write properties may now be invoked in a sequence. A backwards-compatible API change is introduced, so now `write_properties` does return the properties written, that unblocks the chaining abstraction. Obsolete method signatures would be already updated. Pydocs updated. Preprocessors configured in `PROPERTIES_WRITE_PREPROCESS_SEQUENCE` are verified and available before any properties writing initiated. `Propertiesnotavailable.py` file renamed, unused imports cleaned; a few typos fixed in ingestion processing user-facing documentation; Testing Done: introduced 3 properties preprocessing functional tests, covering success/error/misconfiguration cases. Signed-off-by: ikoleva <[email protected]>
There was a problem hiding this comment.
As it's a introducing a new user-facing options, we should include a functional test under https://github.com/vmware/versatile-data-kit/tree/main/projects/vdk-core/tests/functional/run to test the PROPERTIES_WRITE_PREPROCESS_SEQUENCE with vdk run
...ects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/datajobs_service_properties.py
Show resolved
Hide resolved
doks5
suggested changes
Apr 28, 2022
...ects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/datajobs_service_properties.py
Show resolved
Hide resolved
...ects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/datajobs_service_properties.py
Show resolved
Hide resolved
This change introduces `IPropertiesServiceClient` `write_properties` chaining, enabling use-cases like decorate/curate properties prior write, parallel properties storage, and so on. In addition, autonomous `IPropertiesServiceClient` write properties may now be invoked in a sequence. A backwards-compatible API change is introduced, so now `write_properties` does return the properties written, that unblocks the chaining abstraction. Obsolete method signatures would be already updated. Pydocs updated. Preprocessors configured in `PROPERTIES_WRITE_PREPROCESS_SEQUENCE` are verified and available before any properties writing initiated. `Propertiesnotavailable.py` file renamed, unused imports cleaned; a few typos fixed in ingestion processing user-facing documentation; Testing Done: introduced 4 properties preprocessing functional tests, covering success/immutableouterscope/error/misconfiguration cases; introduced a functional test using PROPERTIES_WRITE_PREPROCESS_SEQUENCE to decorate with an additional property, via newly implemented TestPropertiesDecoratedPlugin in vdk-test-utils Signed-off-by: ikoleva <[email protected]>
the functional test is implemented; should I comment it out however, and create a PR with vdk-test-utils changes to merge first? |
doks5
approved these changes
Apr 28, 2022
projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_plugins.py
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Apr 29, 2022
You can merge both in the same PR - our CI uses vdk-test-utils from the source. |
This change introduces `IPropertiesServiceClient` `write_properties` chaining, enabling use-cases like decorate/curate properties prior write, parallel properties storage, and so on. In addition, autonomous `IPropertiesServiceClient` write properties may now be invoked in a sequence. A backwards-compatible API change is introduced, so now `write_properties` does return the properties written, that unblocks the chaining abstraction. Obsolete method signatures would be already updated. Pydocs updated. Preprocessors configured in `PROPERTIES_WRITE_PREPROCESS_SEQUENCE` are verified and available before any properties writing initiated. `Propertiesnotavailable.py` file renamed, unused imports cleaned; a few typos fixed in ingestion processing user-facing documentation; Testing Done: introduced 4 properties preprocessing functional tests, covering success/immutableouterscope/error/misconfiguration cases; introduced a functional test using PROPERTIES_WRITE_PREPROCESS_SEQUENCE to decorate with an additional property, via newly implemented TestPropertiesDecoratedPlugin in vdk-test-utils Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces
IPropertiesServiceClientwrite_propertieschaining, enabling use-cases like decorate/curate properties
prior write, parallel properties storage, and so on.
In addition, autonomous
IPropertiesServiceClientwrite properties maynow be invoked in a sequence.
A backwards-compatible API change is introduced, so now
write_propertiesdoes return the properties written, that unblocksthe chaining abstraction. Obsolete method signatures would be already
updated. Pydocs updated.
Preprocessors configured in
PROPERTIES_WRITE_PREPROCESS_SEQUENCEareverified and available before any properties writing initiated.
Propertiesnotavailable.pyfile renamed, unused imports cleaned;a few typos fixed in ingestion processing user-facing documentation;
Testing Done: introduced 3 properties preprocessing functional tests,
covering success/error/misconfiguration cases.
Signed-off-by: ikoleva [email protected]