vdk-core: encapsulate router-specific properties logic #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This MR attempts to simplify outer usages of PropertiesRouter, in equivalent to IngesterRouter. The reason is IngesterRouter does support multiple ingesters evaluated in a sequence, and PropertiesRouter supports singleton properties back-end implementation yet. PropertiesRouter interface surface no more exposes a singleton implementation, instead implements the IProperties interface and does the routing internally. Also IngesterRouter already implements IIngester methods, so elaborated the class definition on that explicitly, so it is effectively coupled with the interfaces evolution. Testing Done: ci/cd. No functional changes made, except interface surface improvements and encapsulation. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Apr 27, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/properties_router.py
Show resolved
Hide resolved
This MR attempts to simplify outer usages of PropertiesRouter, in equivalent to IngesterRouter. The reason is IngesterRouter does support multiple ingesters evaluated in a sequence, and PropertiesRouter supports singleton properties back-end implementation yet. PropertiesRouter interface surface no more exposes a singleton implementation, instead implements the IProperties interface and does the routing internally. Also IngesterRouter already implements IIngester methods, so elaborated the class definition on that explicitly, so it is effectively coupled with the interfaces evolution. Testing Done: ci/cd. No functional changes made, except interface surface improvements and encapsulation. Signed-off-by: ikoleva <[email protected]>
|
The change looks good to me. But I am wondering what prompted the change now? |
A prerequisite for multi properties client invocation support, like mentioned in the description, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR attempts to simplify outer usages of PropertiesRouter,
in equivalent to IngesterRouter. The reason is IngesterRouter does
support multiple ingesters evaluated in a sequence, and PropertiesRouter
supports singleton properties back-end implementation yet.
PropertiesRouter interface surface no more exposes a singleton
implementation, instead implements the IProperties interface and
does the routing internally.
Also IngesterRouter already implements IIngester methods, so elaborated
the class definition on that explicitly, so it is effectively coupled
with the interfaces evolution.
Testing Done: ci/cd. No functional changes made, except interface
surface improvements and encapsulation.
Signed-off-by: ikoleva [email protected]