vdk-server: add automated tests #3103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server Now installation fails with error like -Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `defaultBackend` or `rules` must be specified Testing Done: vdk server --install succeeded locally. Separate PR is working on adding automated tests.
Lack of regression testing in vdk-server natually leads to its instability due to changes in Control Service helm chart. This is adding smoke test to make sure basic functionality works. Testing Done: tests
antoniivanov
force-pushed
the
person/aivanov/dag
branch
2 times, most recently
from
93cd099 to
4356490
Compare
antoniivanov
added a commit
that referenced
this pull request
Feb 13, 2024
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server Now installation fails with error like -Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `defaultBackend` or `rules` must be specified This change also - Addressed a TODO about command description - Added missing dependency. Testing Done: vdk server --install succeeded locally. Separate [PR](#3103) is working on adding automated tests.
duyguHsnHsn
approved these changes
Feb 14, 2024
murphp15
approved these changes
Feb 15, 2024
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of regression testing in vdk-server natually leads to its instability due to changes in Control Service helm chart. This is adding smoke test to make sure basic functionality works.
Testing Done: tests