vdk-server: fix ingress settings #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/dag
branch
5 times, most recently
from
113cbd8 to
97ed5ac
Compare
antoniivanov
force-pushed
the
person/aivanov/dag
branch
4 times, most recently
from
c4f99c9 to
06840cc
Compare
projects/vdk-plugins/vdk-server/src/vdk/plugin/server/server_plugin.py
Outdated
Show resolved
Hide resolved
yonitoo
approved these changes
Feb 12, 2024
antoniivanov
force-pushed
the
person/aivanov/dag
branch
from
06840cc to
93cd099
Compare
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server Now installation fails with error like -Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `defaultBackend` or `rules` must be specified Testing Done: vdk server --install succeeded locally. Separate PR is working on adding automated tests.
antoniivanov
force-pushed
the
person/aivanov/dag
branch
from
93cd099 to
4356490
Compare
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server Now installation fails with error like -Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either `defaultBackend` or `rules` must be specified Testing Done: vdk server --install succeeded locally. Separate PR is working on adding automated tests.
DeltaMichael
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5369fc6 ingress configuraiton was made more configurable but the defaults were removed and that broke vdk-server
Now installation fails with error like
-Stderr output: Error: INSTALLATION FAILED: release vdk failed, and has been uninstalled due to atomic being set: Ingress.extensions "vdk-pipelines-control-service" is invalid: spec: Invalid value: []networking.IngressRule(nil): either
defaultBackendorrulesmust be specifiedThis change also
Testing Done: vdk server --install succeeded locally. Separate PR is
working on adding automated tests.