Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: ingest logging formatting bug #2836

Merged
merged 1 commit into from
Nov 13, 2023
+7 −15
Merged

vdk-core: ingest logging formatting bug #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ def __get_ingester(self, method: str) -> IngesterBase:
else:
errors.report_and_throw(
VdkConfigurationError(
"Provided method, {method}, has invalid value.",
"VDK was run with method={method}, however {method} is not part of the available ingestion mechanisms.",
f"Provided method, {method}, has invalid value."
f"VDK was run with method={method}, however {method} is not part of the available ingestion methods."
f"Provide either valid value for method, or install ingestion plugin that supports this type. "
f"Currently possible values are {list(self._ingester_builders.keys())}",
f"Currently possible values are {list(self._ingester_builders.keys())}"
)
)

Expand Down Expand Up @@ -217,15 +217,9 @@ def __initialize_processor(self, method) -> Optional[IIngesterPlugin]:
if processor_plugin is None:
errors.report_and_throw(
VdkConfigurationError(
"Could not create new processor plugin of type" f" {method}.",
f"VDK was run with method={method}, however "
"no valid ingestion processor plugin was "
"created.",
"Seems to be a bug in the plugin for method"
f" {method}. Make sure it's correctly "
f"installed. If upgraded recently, consider"
" reverting to previous version. Or use "
"another method type.",
"Could not create new processor plugin of method: " f"{method}.",
f"Currently possible processor methods are {list(self._ingester_builders.keys())}. "
"Make sure the processing configuration value are correct and the plugin is installed. ",
)
)
return processor_plugin
Expand Down
4 changes: 1 addition & 3 deletions projects/vdk-core/tests/vdk/internal/builtin_plugins/ingestion/test_ingester_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,4 @@ def test_router_raise_error_chained_ingest_plugins_not_registered():
router.send_tabular_data_for_ingestion(rows=["b"], column_names=["a"])

error_msg = exc_info.value
assert "Could not create new processor plugin of type pre-ingest-test" in str(
error_msg
)
assert "method: pre-ingest-test" in str(error_msg)