vdk-core: ingest logging formatting bug #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielgeorgiev1
approved these changes
Oct 25, 2023
DeltaMichael
approved these changes
Oct 25, 2023
murphp15
approved these changes
Oct 26, 2023
antoniivanov
force-pushed
the
person/aivanov/ingest
branch
2 times, most recently
from
d176311 to
78f8065
Compare
The logs were not replacing the method name because the f-string was missing the `f"` so this is fixed. Slightly simplified the error message to make it easier to understand I hope Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/ingest
branch
from
bf72fd5 to
09df358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs were not replacing the method name because the f-string was missing the
f"so this is fixed.Slightly simplified the error message to make it easier to understand I hope