-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: integration test for async job deploy #2829
Conversation
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
As we discussed the test had to be reworked as per @antoniivanov 's comment - #2781 (comment), but I don't think this is the case. Also, you should verify all deployment fields not just 3-4 after each operation through the APIs. |
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
The test couldn't be refactored into multiple smaller test cases, since there is apparently some intrinsic state that is lost when executing different test cases. I refactored the larger test cases to call different methods (which were supposed to be ordered tests) and it works that way. When I try to make them into different test cases they fail. I am also checking all fields except for resources - since they aren't supported yet and if I set them via the POST request the test fails : Lines 203 to 217 in ff1156a
|
...ce/src/integration-test/java/com/vmware/taurus/service/deploy/DataJobDeploymentCrudITV2.java
Outdated
Show resolved
Hide resolved
...ce/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobDeploymentCrudAsyncIT.java
Outdated
Show resolved
Hide resolved
...ice/src/integration-test/java/com/vmware/taurus/datajobs/it/BaseDataJobDeploymentCrudIT.java
Outdated
Show resolved
Hide resolved
...ce/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobDeploymentCrudAsyncIT.java
Outdated
Show resolved
Hide resolved
...ce/src/integration-test/java/com/vmware/taurus/service/deploy/DataJobDeploymentCrudITV2.java
Outdated
Show resolved
Hide resolved
...service/src/integration-test/java/com/vmware/taurus/datajobs/it/DataJobDeploymentCrudIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
...ice/src/integration-test/java/com/vmware/taurus/datajobs/it/BaseDataJobDeploymentCrudIT.java
Outdated
Show resolved
Hide resolved
...ice/src/integration-test/java/com/vmware/taurus/datajobs/it/BaseDataJobDeploymentCrudIT.java
Outdated
Show resolved
Hide resolved
...ice/src/integration-test/java/com/vmware/taurus/datajobs/it/BaseDataJobDeploymentCrudIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
what: Add integration test that checks the status of the database when using the new data jobs deployment synchronizer. why: part of the https://github.com/vmware/versatile-data-kit/tree/main/specs/vep-2272-complete-data-job-configuration-persistence VEP testing: n/a --------- Signed-off-by: mrMoZ1 <[email protected]> Co-authored-by: github-actions <>
what: Add integration test that checks the status of the database when using the new data jobs deployment synchronizer.
why: part of the https://github.com/vmware/versatile-data-kit/tree/main/specs/vep-2272-complete-data-job-configuration-persistence VEP
testing: n/a