Revert "control-service: introduce data job deployment entity" #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3909c0c.
doks5
approved these changes
Sep 7, 2023
antoniivanov
approved these changes
Sep 7, 2023
Signed-off-by: mrMoZ1 <[email protected]>
mrMoZ1
deleted the
revert-2613-person/miroslavi/introduce-data-job-deployment-entity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
Reverts #2613
why:
Adopting latest tpcs showed requests getting slow and taking a long time to complete. Investigating against a locally running tpcs instance hooked to a k8s cluster revealed the following results from executing (multiple times) a query that retrieves all data jobs.:
HEAD is now at 3909c0c control-service: introduce data job deployment entity (#2613) -> 1.6.986170982 -> Query took more than a minute to complete.
Previous HEAD position was 3909c0c control-service: introduce data job deployment entity (#2613)
HEAD is now at 98471d8 Update README.md -> 1.6.978504774 - > Query took ~ second to complete.
Conclusion commit - > 3909c0c control-service: introduce data job deployment entity makes requests slow.
testing:
Checked out the reverted branch from this commit and made the same request. It now takes ~ second to complete.
N/a reverting so existing CI/CD should suffice.