control-service: introduce data job deployment entity #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
force-pushed
the
person/miroslavi/introduce-data-job-deployment-entity
branch
2 times, most recently
from
e73f954 to
45b9ae4
Compare
antoniivanov
approved these changes
Aug 28, 2023
mivanov1988
force-pushed
the
person/miroslavi/introduce-data-job-deployment-entity
branch
from
1a4f3a3 to
9d68860
Compare
Why As part of the VEP-2272 we need to switch the source of truth from Kubernetes to the database. What Implemented a database table named "data_job_deployment," designated for the storage of all data associated with data job deployments. Testing Done Unit tests Signed-off-by: Miroslav Ivanov [email protected]
mivanov1988
force-pushed
the
person/miroslavi/introduce-data-job-deployment-entity
branch
from
9cb6e8c to
0a811d9
Compare
dakodakov
reviewed
Aug 29, 2023
...pelines_control_service/src/main/java/com/vmware/taurus/service/model/DataJobDeployment.java
Show resolved
Hide resolved
dakodakov
approved these changes
Aug 29, 2023
mivanov1988
deleted the
person/miroslavi/introduce-data-job-deployment-entity
branch
mrMoZ1
pushed a commit
that referenced
this pull request
Sep 7, 2023
what: Reverts #2613 why: Adopting latest tpcs showed requests getting slow and taking a long time to complete. Investigating against a locally running tpcs instance hooked to a k8s cluster revealed the following results from executing (multiple times) a query that retrieves all data jobs.: HEAD is now at 3909c0c control-service: introduce data job deployment entity (#2613) -> 1.6.986170982 -> **Query took more than a minute to complete.** Previous HEAD position was 3909c0c control-service: introduce data job deployment entity (#2613) HEAD is now at 98471d8 Update README.md -> 1.6.978504774 - > **Query took ~ second to complete.** Conclusion commit - > 3909c0c control-service: introduce data job deployment entity makes requests slow. testing: Checked out the reverted branch from this commit and made the same request. It now takes ~ second to complete. N/a reverting so existing CI/CD should suffice. --------- Signed-off-by: mrMoZ1 <[email protected]> Co-authored-by: github-actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As part of the VEP-2272, we need to switch the source of truth from Kubernetes to the database.
What
Implemented a database table named "data_job_deployment," designated for the storage of all data associated with data job deployments.
Testing Done
Unit tests
Signed-off-by: Miroslav Ivanov [email protected]