vdk-core: revert "vdk-core: add vdk sql-query command (#2512)" #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c3d492. Why This commit causes a circular dependency in the following modules standalone_data_job -> builtin_hook_impl -> query_command_plugin -> standalone_data_job What Revert the commit How was this tested Ran vdk-ipython tests locally, because they caught the circular dependency initially What kind of change is this Bugfix
antoniivanov
approved these changes
Aug 14, 2023
yonitoo
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This reverts commit 2c3d492, because it causes a circular dependency in the following modules
standalone_data_job -> builtin_hook_impl -> query_command_plugin -> standalone_data_job
What
Revert the commit
How was this tested
Ran vdk-ipython tests locally, because they caught the circular dependency initially
What kind of change is this
Bugfix