Skip to content

Commit

Permalink
vdk-core: revert "vdk-core: add vdk sql-query command (#2512)" (#2549)
Browse files Browse the repository at this point in the history
## Why

This reverts commit 2c3d492, because it
causes a circular dependency in the following modules

standalone_data_job -> builtin_hook_impl -> query_command_plugin ->
standalone_data_job

## What

Revert the commit

## How was this tested

Ran vdk-ipython tests locally, because they caught the circular
dependency initially

## What kind of change is this

Bugfix

Co-authored-by: Dilyan Marinov <[email protected]>
  • Loading branch information
DeltaMichael and Dilyan Marinov authored Aug 14, 2023
1 parent 1548f60 commit bf0eab0
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 160 deletions.
1 change: 0 additions & 1 deletion projects/vdk-core/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,3 @@ pytest-randomly
pytest-sugar
reorder-python-imports
smtpdfix
vdk-sqlite
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
from vdk.internal.builtin_plugins.connection.connection_plugin import (
QueryDecoratorPlugin,
)
from vdk.internal.builtin_plugins.connection.query_command_plugin import (
QueryCommandPlugin,
)
from vdk.internal.builtin_plugins.debug.debug import DebugPlugins
from vdk.internal.builtin_plugins.ingestion.ingester_configuration_plugin import (
IngesterConfigurationPlugin,
Expand Down Expand Up @@ -133,7 +130,6 @@ def vdk_start(plugin_registry: PluginRegistry, command_line_args: List) -> None:
# connection plugins
plugin_registry.add_hook_specs(ConnectionHookSpec)
plugin_registry.load_plugin_with_hooks_impl(QueryDecoratorPlugin())
plugin_registry.load_plugin_with_hooks_impl(QueryCommandPlugin())


@hookimpl(tryfirst=True)
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit bf0eab0

Please sign in to comment.