control-service: job-builder-secure using kaniko fix #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same fix as applied on job-builder here (#2429) need to be applied on job-builder-secure This also slightly refactors and simplifies the image build code by reusing the job-builder image thus reducing unneeded duplication. There were a few previous fixes in job-builder that were never ported to job-builder-secure. Added a bit more clear readme.
mivanov1988
approved these changes
Jul 24, 2023
antoniivanov
changed the title
murphp15
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same fix as applied on job-builder here
(#2429) need to be applied on job-builder-secure
This also slightly refactors and simplifies the image build code by reusing the job-builder image thus reducing unneeded duplication. There were a few previous fixes in job-builder that were never ported to job-builder-secure.
Added a bit more clear readme.