control-service: job-builder using kaniko fix #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/cs
branch
5 times, most recently
from
dedbfa4 to
09955b0
Compare
The way we are preparing our job-builder image is like this: ``` FROM gcr.io/kaniko-project/executor FROM alpine COPY --from=0 /kaniko /kaniko ``` This is apparently known issue : https://github.com/GoogleContainerTools/kaniko#known-issues > Running kaniko in any Docker image other than the official kaniko image is not supported (ie YMMV). > This includes copying the kaniko executables from the official image into another image. So instead making sure we built from kaniko image directly should fix the issue See #2391 Google Java Format control-service: job-builder uisng kaniko fix
antoniivanov
force-pushed
the
person/aivanov/cs
branch
from
85e2537 to
e51948f
Compare
mivanov1988
reviewed
Jul 20, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/EcrRegistryInterface.java
Show resolved
Hide resolved
mivanov1988
reviewed
Jul 20, 2023
...ipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerImageName.java
Show resolved
Hide resolved
mivanov1988
reviewed
Jul 20, 2023
...ipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageBuilder.java
Show resolved
Hide resolved
|
Good job! |
mivanov1988
approved these changes
Jul 20, 2023
mivanov1988
reviewed
Jul 20, 2023
...ipelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageBuilder.java
Show resolved
Hide resolved
doks5
approved these changes
Jul 20, 2023
antoniivanov
added a commit
that referenced
this pull request
Jul 24, 2023
The same fix as applied on job-builder here (#2429) need to be applied on job-builder-secure This also slightly refactors and simplifies the image build code by reusing the job-builder image thus reducing unneeded duplication. There were a few previous fixes in job-builder that were never ported to job-builder-secure. Added a bit more clear readme.
antoniivanov
added a commit
that referenced
this pull request
Jul 24, 2023
The same fix as applied on job-builder here (#2429) need to be applied on job-builder-secure This also slightly refactors and simplifies the image build code by reusing the job-builder image thus reducing unneeded duplication. There were a few previous fixes in job-builder that were never ported to job-builder-secure. Added a bit more clear readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we are preparing our job-builder image is like this:
This is apparently known issue and caused this outage described in #2391
https://github.com/GoogleContainerTools/kaniko#known-issues
So instead making sure we built from kaniko image directly should fix the issue
See #2391
Testing Done: Beyond automated tests I also tested it in one of environments where the issue in #2391 reproduce and verified with the new image the jobs are correctly built.