vdk-jupyter: convert job operation #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide screenshot highlighting any UI changes |
yonitoo
reviewed
Jul 14, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/handlers.py
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jul 14, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
murphp15
reviewed
Jul 14, 2023
...cts/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/ConvertJobToNotebook.tsx
Show resolved
Hide resolved
murphp15
reviewed
Jul 14, 2023
...cts/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/ConvertJobToNotebook.tsx
Outdated
Show resolved
Hide resolved
murphp15
approved these changes
Jul 14, 2023
duyguHsnHsn
changed the title
...cts/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/convert_job.py
Outdated
Show resolved
Hide resolved
...cts/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/convert_job.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/handlers.py
Show resolved
Hide resolved
...cts/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/convert_job.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Jul 21, 2023
for more information, see https://pre-commit.ci
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-transform-job-operation
branch
from
24fae57 to
0ee684d
Compare
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-transform-job-operation
branch
from
a6b10df to
cf4e4c4
Compare
for more information, see https://pre-commit.ci
…m:vmware/versatile-data-kit into person/hduygu/vdk-transform-job-operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This change includes:
More info for the operation can be found: https://github.com/vmware/versatile-data-kit/wiki/VDK-Jupyter-Integration-Convert-Job-Operation
Testing: python unit tests, TBD: jest tests
Example of how transformed job looks like:
This is how a transformed job would look like, no UI changes are introduced in this PR
Signed-off-by: Duygu Hasan [email protected]