Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-plugins: remove global "variables" in CI #1730

Closed
wants to merge 1 commit into from
Closed

vdk-plugins: remove global "variables" in CI #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/vdk-plugins/.plugin-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
artifacts:
when: always
reports:
junit: tests.xml
junit: "projects/vdk-plugins/$PLUGIN_NAME/tests.xml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may you link a pipeline before/after?

nit: the PR description does not seem to match the draft changes 👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a draft . I am still working on the change. And I needed to test using the Gitlab CI since I cannot locally as easily for this.

Anyhow I opened a PR for the change since it should be separate from this one : #1732


.build-plugin-on-vdk-core-release:
stage: pre_release_test
Expand Down
1 change: 0 additions & 1 deletion projects/vdk-plugins/vdk-impala/.plugin-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Copyright 2021-2023 VMware, Inc.
# SPDX-License-Identifier: Apache-2.0

image: "python:3.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: those are redundant, since overwritten? what's the effective python version definition?


.build-vdk-impala:
variables:
Expand Down
2 changes: 0 additions & 2 deletions projects/vdk-plugins/vdk-ingest-http/.plugin-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Copyright 2021-2023 VMware, Inc.
# SPDX-License-Identifier: Apache-2.0

image: "python:3.7"

.build-vdk-ingest-http:
variables:
PLUGIN_NAME: vdk-ingest-http
Expand Down
1 change: 0 additions & 1 deletion projects/vdk-plugins/vdk-plugin-control-cli/.plugin-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Copyright 2021-2023 VMware, Inc.
# SPDX-License-Identifier: Apache-2.0

image: "python:3.7"

.build-vdk-plugin-control-cli:
variables:
Expand Down