vdk-plugins: remove global "variables" in CI #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of effort to stabilize builds - #1559 I am removing global variables and names since they can be overwriten by accident across differnet projects. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-ci
branch
from
a38fde7 to
01564db
Compare
ivakoleva
reviewed
Mar 10, 2023
| @@ -27,7 +27,7 @@ | |||
| artifacts: | |||
| when: always | |||
| reports: | |||
| junit: tests.xml | |||
| junit: "projects/vdk-plugins/$PLUGIN_NAME/tests.xml" | |||
There was a problem hiding this comment.
may you link a pipeline before/after?
nit: the PR description does not seem to match the draft changes 👀
There was a problem hiding this comment.
It's a draft . I am still working on the change. And I needed to test using the Gitlab CI since I cannot locally as easily for this.
Anyhow I opened a PR for the change since it should be separate from this one : #1732
| @@ -1,7 +1,6 @@ | |||
| # Copyright 2021-2023 VMware, Inc. | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| image: "python:3.7" | |||
There was a problem hiding this comment.
nit: those are redundant, since overwritten? what's the effective python version definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of effort to stabilize builds -
#1559
I am removing global variables and names since they can be overwriten by accident across differnet projects.