vdk-impala: fix impala template empty source view usr err #1189
Conversation
Signed-off-by: mrMoZ1 <[email protected]>
mrMoZ1
force-pushed
the
person/mzhivkov/fix-impala-template-regression
branch
from
e9cfbb7 to
78f95ea
Compare
|
I will never tire asking this :) Tests ? Any bug we fix should have tests. I am surprised that no tests fail (clearly we have not added tests covering this scenario - what happens if SQL view returns 0 rows) but now it's a good opportunity to do so |
Tests will likely fail. And I will update the MR accordingly. |
Signed-off-by: mrMoZ1 <[email protected]>
projects/vdk-plugins/vdk-impala/tests/functional/template_regression_test.py
Outdated
Show resolved
Hide resolved
|
Some small comment around test verification but looks good to me. Thanks. |
| assert "Source view returned no results." in res.exception.args[0] | ||
| assert isinstance(res.exception, errors.UserCodeError) | ||
| assert not res.exception | ||
| assert res.exit_code == 0 |
There was a problem hiding this comment.
I know it's merged but I am leaving the comment for future reference (we can leave it now this way) :
There's util cli_assert (https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_funcs.py#L53) utility that should be used, It prints a lot of more details about the execution if the assert fails.
what: The template arguments validator now makes use of the skip_remaining_steps() method when an empty source view is returned. why: Users of the template requested that empty source view stopped resulting in a User Error, after a discussion it was agreed that this is the correct and desired behaviour. testing: this change depends on #1188 Edited failing regression tests. Signed-off-by: Momchil Zhivkov [email protected]
what: The template arguments validator now makes use of the skip_remaining_steps() method when an empty source view is returned.
why: Users of the template requested that empty source view stopped resulting in a User Error, after a discussion it was agreed that this is the correct and desired behaviour.
testing: this change depends on #1188
Edited failing regression tests.
Signed-off-by: Momchil Zhivkov [email protected]