vdk-core: add ability to cancel remaining job steps #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
requested changes
Sep 23, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/data_job.py
Outdated
Show resolved
Hide resolved
|
I think this is a cool new feature. I've talked with some users in the past who have complained they cannot stop a job in the middle. We should popularize it after releasing it. Thanks for coming up with it. |
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
approved these changes
Sep 26, 2022
Signed-off-by: mrMoZ1 <[email protected]>
| @@ -146,7 +146,7 @@ def invoke_run_function(func: Callable, job_input: IJobInput, step_name: str): | |||
| what_happened=f"Data Job step {step_name} completed with error.", | |||
| why_it_happened=errors.MSG_WHY_FROM_EXCEPTION(e), | |||
| consequences="I will not process the remaining steps (if any), " | |||
| "and this Data Job execution will be marked as failed.", | |||
There was a problem hiding this comment.
I didn't notice this. That's why I dislike the exception approach for control flow (as i mentioned before).
Isn't it better to catch teh exception and handle it, re-raise it. I think this will print an error in the logs - but we have not error (and that may confure users)
mrMoZ1
pushed a commit
that referenced
this pull request
Sep 27, 2022
what: The template arguments validator now makes use of the skip_remaining_steps() method when an empty source view is returned. why: Users of the template requested that empty source view stopped resulting in a User Error, after a discussion it was agreed that this is the correct and desired behaviour. testing: this change depends on #1188 Edited failing regression tests. Signed-off-by: Momchil Zhivkov [email protected]
antoniivanov
pushed a commit
that referenced
this pull request
Sep 29, 2022
what: Added the ability to cancel the remaining job/template steps through the job_input interface. why: This feature is required by users in certain cases e.g: if a data job depends on processing data from a source which has indicated no new entries since last run, then we can skip the execution. testing: Tested locally with data job/templates and added functional tests. Signed-off-by: Momchil Zhivkov [email protected]
antoniivanov
pushed a commit
that referenced
this pull request
Sep 29, 2022
what: The template arguments validator now makes use of the skip_remaining_steps() method when an empty source view is returned. why: Users of the template requested that empty source view stopped resulting in a User Error, after a discussion it was agreed that this is the correct and desired behaviour. testing: this change depends on #1188 Edited failing regression tests. Signed-off-by: Momchil Zhivkov [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Added the ability to cancel the remaining job/template steps through the job_input interface.
why: This feature is required by users in certain cases e.g: if a data job depends on processing data from a source which has indicated no new entries since last run, then we can skip the execution.
testing: Tested locally with data job/templates and added functional tests.
Signed-off-by: Momchil Zhivkov [email protected]