Add metadata for OpenAPI VDC networks #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
added 2 commits
April 5, 2022 09:26
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
mikeletux
as code owners
Signed-off-by: abarreiro <[email protected]>
lvirbalas
approved these changes
Apr 5, 2022
mikeletux
approved these changes
Apr 5, 2022
vbauzys
suggested changes
Apr 5, 2022
Signed-off-by: abarreiro <[email protected]>
vbauzys
approved these changes
Apr 5, 2022
Didainius
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a workaround for OpenAPI VDC networks metadata functions to work with XML endpoints while the final OpenAPI implementation remains unreleased.
The PR that contains the final implementation is #455
The other option that came in to my mind was not to do these functions that operate on a
OpenApiOrgVdcNetworkobject and just use theOrgVDCNetworkones that we currently have, but the result was an spaghetti on Terraform Provider part that would be harder to clean afterwards.This option just hides the details in the new provided functions, so refactoring later would be super easy (in fact is already done in #455, we just need to wait).