Waiting: Add OpenAPI metadata methods for OpenAPI VDC Networks #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
added 3 commits
April 1, 2022 15:53
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
commented
Apr 4, 2022
govcd/metadata.go
Outdated
| @@ -91,58 +91,16 @@ func (vapp *VApp) GetMetadata() (*types.Metadata, error) { | |||
| return getMetadata(vapp.client, vapp.VApp.HREF) | |||
| } | |||
|
|
|||
| func getMetadata(client *Client, requestUri string) (*types.Metadata, error) { | |||
There was a problem hiding this comment.
Just moved these private functions to the bottom for the sake of ordering a bit.
adambarreiro
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
mikeletux
as code owners
adambarreiro
removed request for
mikeletux,
lvirbalas,
dataclouder,
Didainius and
vbauzys
|
Going back to draft state |
added 2 commits
April 5, 2022 09:28
This reverts commit bfd26e8. Signed-off-by: abarreiro <[email protected]>
This reverts commit 84c2652. Signed-off-by: abarreiro <[email protected]>
adambarreiro
force-pushed
the
add-metadata-network-v2
branch
from
806630f to
618c29b
Compare
Signed-off-by: abarreiro <[email protected]>
adambarreiro
changed the title
added 4 commits
August 8, 2022 09:42
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims for two things:
However, metadata support in OpenAPI is still in
alphastatus, so this PR must remain in Draft.