Use prerelease info when looking up conformance image #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream publishes prerelease images so there is no need to throw that info away. It is a remnant of Heptio publishing their own images. In addition, if we're using that info we dont need to warn about the existence of prerelease info and never really needed to warn about the metadata on the version. As a result we can remove that entire warning check/log. Fixes #976 Fixes #977 Signed-off-by: John Schnake <[email protected]>
zubron
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upstream publishes prerelease images so there is no need to throw
that info away. It is a remnant of Heptio publishing their own
images.
In addition, if we're using that info we dont need to warn about
the existence of prerelease info and never really needed to warn
about the metadata on the version. As a result we can remove that
entire warning check/log.
Which issue(s) this PR fixes
Fixes #976
Fixes #977
Special notes for your reviewer:
Release note: