Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not use prerelease info for conformance image picking? #977

Closed
johnSchnake opened this issue Oct 25, 2019 · 1 comment · Fixed by #978
Closed

Why not use prerelease info for conformance image picking? #977

johnSchnake opened this issue Oct 25, 2019 · 1 comment · Fixed by #978
Labels
p2-moderate

Comments

@johnSchnake
Copy link
Contributor

The prerelease versions also get their conformance image built (in the upstream process) so I don't see why we would need to warn anyone at all. This would require that we change the conformance image version we choose based on the cluster version slightly but seems appropriate. Will create another issue for that.

Originally posted by @johnSchnake in #976 (comment)
@johnSchnake
Copy link
Contributor Author

See images listed here: https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/conformance?gcrImageListsize=30

@johnSchnake johnSchnake mentioned this issue Oct 25, 2019
Merged
johnSchnake added a commit that referenced this issue Oct 25, 2019
@johnSchnake
Use prerelease info when looking up conformance image (#978)
871ba62 
Upstream publishes prerelease images so there is no need to throw
that info away. It is a remnant of Heptio publishing their own
images.

In addition, if we're using that info we dont need to warn about
the existence of prerelease info and never really needed to warn
about the metadata on the version. As a result we can remove that
entire warning check/log.

Fixes #976
Fixes #977

Signed-off-by: John Schnake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2-moderate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use prerelease info when looking up conformance image
1 participant
@johnSchnake