Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker.GatherResults doesn't make it possible to close the results file #75

Closed
ncdc opened this issue Sep 21, 2017 · 0 comments
Closed

worker.GatherResults doesn't make it possible to close the results file #75

ncdc opened this issue Sep 21, 2017 · 0 comments
Labels
p1-important

Comments

@ncdc
Copy link
Contributor

ncdc commented Sep 21, 2017

It calls DoRequest and returns an io.Reader, so it never closes the file it opens.
@timothysc timothysc added this to the v0.9.0 milestone Sep 21, 2017
@timothysc timothysc self-assigned this Sep 21, 2017
timothysc added a commit to timothysc/sonobuoy that referenced this issue Oct 2, 2017
@timothysc
Fixes vmware-tanzu#75 - Cleanup stale file handle
4c947ed 
Signed-off-by: Timothy St. Clair <[email protected]>
@timothysc timothysc mentioned this issue Oct 2, 2017
Merged
timothysc added a commit to timothysc/sonobuoy that referenced this issue Oct 3, 2017
@timothysc
Fixes vmware-tanzu#75 - Cleanup stale file handle
c52e2c2 
Signed-off-by: Timothy St. Clair <[email protected]>
timothysc added a commit that referenced this issue Oct 3, 2017
@timothysc
Merge pull request #92 from timothysc/cleanup
d8711aa 
Fixes #75 - Cleanup stale file handle
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this issue Jun 27, 2018
@timothysc
Fixes vmware-tanzu#75 - Cleanup stale file handle
599e36b 
Signed-off-by: Timothy St. Clair <[email protected]>

Signed-off-by: Jesse Hamilton [email protected]
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this issue Jun 27, 2018
@timothysc
Merge pull request vmware-tanzu#92 from timothysc/cleanup
e8b8fa3 
Fixes vmware-tanzu#75 - Cleanup stale file handle
Signed-off-by: Jesse Hamilton [email protected]
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this issue Jun 27, 2018
@timothysc
Fixes vmware-tanzu#75 - Cleanup stale file handle
4faf812 
Signed-off-by: Timothy St. Clair <[email protected]>

Signed-off-by: Jesse Hamilton [email protected]

Signed-off-by: Jesse Hamilton [email protected]
jhamilton1 pushed a commit to jhamilton1/sonobuoy that referenced this issue Jun 27, 2018
@timothysc
Merge pull request vmware-tanzu#92 from timothysc/cleanup
e983871 
Fixes vmware-tanzu#75 - Cleanup stale file handle
Signed-off-by: Jesse Hamilton [email protected]

Signed-off-by: Jesse Hamilton [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p1-important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncdc @timothysc