Fixes vmware-tanzu#75 - Cleanup stale file handle

Signed-off-by: Timothy St. Clair <[email protected]>
timothysc · Oct 3, 2017 · c52e2c2 · c52e2c2
1 parent 9863dd2
commit c52e2c2
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/pkg/worker/worker.go b/pkg/worker/worker.go
@@ -36,6 +36,7 @@ import (
 func GatherResults(waitfile string, url string) error {
 	var inputFileName []byte
 	var err error
+	var outfile *os.File
 
 	// just loop looking for a file.
 	done := false
@@ -60,9 +61,16 @@ func GatherResults(waitfile string, url string) error {
 		url += "." + filenameParts[1]
 	}
 
+	defer func() {
+		if outfile != nil {
+			outfile.Close()
+		}
+	}()
+
 	// transmit back the results file.
 	return DoRequest(url, func() (io.Reader, error) {
-		outfile, err := os.Open(s)
+		outfile, err = os.Open(s)
 		return outfile, errors.WithStack(err)
 	})
+
 }