This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Improvements in smoke tests #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
owner/docs
karuppiah7890
suggested changes
Nov 12, 2021
test/smoke/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Outdated
Show resolved
Hide resolved
karuppiah7890
suggested changes
Nov 12, 2021
test/smoke/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Outdated
Show resolved
Hide resolved
test/smoke/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Outdated
Show resolved
Hide resolved
karuppiah7890
suggested changes
Nov 12, 2021
test/smoke/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Outdated
Show resolved
Hide resolved
|
In short, these are some things we could do as part of this PR or another PR
|
- Kubectl wait command is used - adding set -o - using kubectl get -o jsonpath or kubectl get -o template for getting status, phase - Change the port from 80 to 8080 Signed-off-by: Aman Sharma <[email protected]>
aman556
force-pushed
the
smoke-tests-improvement
branch
from
d5e552d to
2478ea8
Compare
karuppiah7890
approved these changes
Nov 12, 2021
test/smoke/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Show resolved
Hide resolved
|
thanks @karuppiah7890 agree with the |
|
Makes sense! 👍 |
|
Btw, the port thing, I didn't realize that it was just a service exposing it. I was thinking it was a port-forward, sorry! Anyways, 8080 is fine too 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR is a follow-up PR to #2246.The changes in this PR are:
test/smokeare improved as per the review comments in the last PR.test/gatekeeperis hooked in thetest/smokeDetails for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: # NA
Describe testing done for PR
make smoke-testis triggered to run all the smoke tests.Special notes for your reviewer
Please refer to #2246 for complete picture.