-
Notifications
You must be signed in to change notification settings - Fork 306
Adding shell scripts tests in e2e-framework #2246
Conversation
FYI - converting this to a "Draft" PR. Please feel free to mark as ready when it's good for reviews |
93a8a6a
to
9d65d79
Compare
Latest approach:
|
@aman556 Could you kindly check the golangci-lint error and fix it? https://github.com/vmware-tanzu/community-edition/runs/4043770738?check_suite_focus=true#step:4:409 |
@aman556 If we plan to add GitHub workflows later in a separate PR, I would recommend updating the PR description including the release notes to reflect the expected state of this PR so that reviewing is easy |
Thanks @karuppiah7890 for the feedback. I have fixed the golangci-lint error and also updated the PR description. |
TODO
|
test/e2e/smoke-test/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Outdated
Show resolved
Hide resolved
General observation - we can rethink our |
test/e2e/smoke-test/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Outdated
Show resolved
Hide resolved
Let's take care of improving and optimizing the sleep / wait strategy in a separate PR |
test/e2e/smoke-test/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Show resolved
Hide resolved
test/e2e/smoke-test/packages/local-path-storage/0.0.20/local-path-storage-test.sh
Show resolved
Hide resolved
ea61ff0
to
5821194
Compare
Why? As some packages do not have testing scripts. Shell scripts in this commit will install package and prerequisites and check it's working and then do the clean up Signed-off-by: Aman Sharma <[email protected]> Signed-off-by: Karuppiah Natarajan <[email protected]>
5821194
to
c804e24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There are still some small nitty gritty things to take care of, which we can take care separately and also some things to smoothen out the rough edges. To avoid longer PR review times and longer PR changes, I'm going to merge this off. Let's pair on the next PR @aman556 and work on the e2e framework including the #2167 PR
I have squashed all the commits and put a small commit message (mostly from the first commit message of all the commits)
Merging it now!
Thanks @karuppiah7890 for giving your time in reviewing this PR and merging it will improve all the above things in the follow-up PR. Agree with all the changes for the improvement of the script. Thanks again Karuppiah means allot. |
What this PR does / why we need it
This PR have two motive in e2e-framework.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #2243
Describe testing done for PR
Run
ginkgo -v -- --packages="" --version="" --guest-cluster-name=""
to check the working of shell scripts.Special notes for your reviewer
The bash scripts to test packages follow these steps:
tanzu package installed list
to check the package which we are testing is already installed or not.tanzu package available list contour.community.tanzu.vmware.com
for fetching the latest version of that package.tanzu package install pkgName --package-name pkgName.community.tanzu.vmware.com -f config.yaml --version "${version}"
to install the package.